-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build ChorusMergeModule (and ChorusHubInstaller?) #299
Comments
Yes we still need to be able to build the ChorusHub installer. |
Per this article, it should be straightforward: |
papeh
added a commit
that referenced
this issue
Dec 8, 2022
* Publish NuGet package for ChorusMergeModule.msm Addresses #299
papeh
added a commit
that referenced
this issue
Dec 12, 2022
* Build Chorus Hub Installer with GitHub Actions * Update a deprecated WiX attribute * clean up (completes #299) * check out help in a clean location
Well, the Chorus Hub installer builds, but when I try to send to it, it fails to get the remote project.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When we moved the build to GitHub Actions building the ChorusMergeModule and ChorusHubInstaller was accidentally left out.
We should add building the ChorusMergeModule to
dotnet.yml
and save it as an artifact.Also check if the ChorusHubInstaller is still needed - in a discussion on slack it was noted:
However, it seems that
ChorusMergeModule.msm
andChorusHubInstaller.msi
got build as part of the regular builds (targetsInstaller ChorusHubInstaller
).Check
build/Chorus.proj
prior to commit e7ab5bc and TC for how it was done in the past.ToDo
dotnet.yml
dotnet.yml
dotnet.yml
) where ChorusMergeModule (and ChorusHubInstaller) is used(in FieldWorks and FLEx Bridge installers)
The text was updated successfully, but these errors were encountered: