Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build ChorusMergeModule (and ChorusHubInstaller?) #299

Open
6 tasks done
ermshiperete opened this issue Sep 23, 2022 · 3 comments
Open
6 tasks done

Build ChorusMergeModule (and ChorusHubInstaller?) #299

ermshiperete opened this issue Sep 23, 2022 · 3 comments

Comments

@ermshiperete
Copy link
Member

ermshiperete commented Sep 23, 2022

When we moved the build to GitHub Actions building the ChorusMergeModule and ChorusHubInstaller was accidentally left out.

We should add building the ChorusMergeModule to dotnet.yml and save it as an artifact.

Also check if the ChorusHubInstaller is still needed - in a discussion on slack it was noted:

Looks like ChorusHub was last released for Windows in 2018 and the most recent successful TC build was in 2017. I don't know what the current process is, if any.
getting rid of build/ may be safe. After so much bit rot, it may be easier to rewrite the installer from scratch if we need to.

However, it seems that ChorusMergeModule.msm and ChorusHubInstaller.msi got build as part of the regular builds (targets Installer ChorusHubInstaller).

Check build/Chorus.proj prior to commit e7ab5bc and TC for how it was done in the past.

ToDo

  • Add building ChorusMergeModule to dotnet.yml
  • Is ChorusHubInstaller still needed/used by anyone?
  • If it is, add building ChorusHubInstaller to dotnet.yml
  • document (e.g. in dotnet.yml) where ChorusMergeModule (and ChorusHubInstaller) is used
    (in FieldWorks and FLEx Bridge installers)
  • (nice to have) automatically stamp copyright dates on both
  • Remove Build/Chorus.proj
@papeh papeh self-assigned this Dec 6, 2022
@jasonleenaylor
Copy link
Contributor

Yes we still need to be able to build the ChorusHub installer.

@papeh
Copy link
Contributor

papeh commented Dec 6, 2022

Per this article, it should be straightforward:
https://drumcoder.co.uk/blog/2022/jun/18/wix-installer-from-github-action/

papeh added a commit that referenced this issue Dec 7, 2022
papeh added a commit that referenced this issue Dec 8, 2022
* Publish NuGet package for ChorusMergeModule.msm

Addresses #299
papeh added a commit that referenced this issue Dec 9, 2022
papeh added a commit that referenced this issue Dec 12, 2022
* Build Chorus Hub Installer with GitHub Actions
* Update a deprecated WiX attribute
* clean up (completes #299)
* check out help in a clean location
@papeh papeh closed this as completed Dec 12, 2022
@papeh
Copy link
Contributor

papeh commented Dec 12, 2022

Well, the Chorus Hub installer builds, but when I try to send to it, it fails to get the remote project.

Exception: The internet server reported that it is having problems. There isn't anything you can do about that except try again later.
   at Chorus.VcsDrivers.Mercurial.HgRepolitory.PullFromTarget(String targetLabel, String targetUri)

@papeh papeh reopened this Dec 12, 2022
@papeh papeh removed their assignment Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants