Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate away from deprecated react-test-renderer #3180

Open
imnasnainaec opened this issue Jun 26, 2024 · 3 comments
Open

Migrate away from deprecated react-test-renderer #3180

imnasnainaec opened this issue Jun 26, 2024 · 3 comments
Labels
frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. Size: L Large sized issue test

Comments

@imnasnainaec
Copy link
Collaborator

Most of our frontend unit tests use react-test-renderer, which is now deprecated: https://react.dev/warnings/react-test-renderer
@imnasnainaec imnasnainaec added frontend test maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. Size: L Large sized issue labels Jun 26, 2024
@imnasnainaec
Copy link
Collaborator Author

Possibly wait on #3041

@imnasnainaec
Copy link
Collaborator Author

imnasnainaec commented Aug 2, 2024 •
edited
Loading

Most of our tests that don't use react-test-renderer do use @testing-library/react, but many of those break when we update the latter package from v14 to v15/v16 (see https://github.com/sillsdev/TheCombine/actions/runs/10197887144/job/28211666947 and #3267 (comment)). It's probably worth resolving that issue before migrating everything away from the former.

@imnasnainaec
Copy link
Collaborator Author

Most of our tests that don't use react-test-renderer do use @testing-library/react, but many of those break when we update the latter package from v14 to v15/v16 (see https://github.com/sillsdev/TheCombine/actions/runs/10197887144/job/28211666947 and #3267 (comment)). It's probably worth resolving that issue before migrating everything away from the former.

@testing-library/react issue resolved in #3295

This was referenced Aug 7, 2024
Merged
Merged
@imnasnainaec imnasnainaec mentioned this issue Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. Size: L Large sized issue test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@imnasnainaec