Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match source against regular expression #115

Open
shouya opened this issue Jun 20, 2024 · 0 comments
Open

Match source against regular expression #115

shouya opened this issue Jun 20, 2024 · 0 comments
Labels
feature request New feature or request

Comments

@shouya
Copy link
Owner

shouya commented Jun 20, 2024

For endpoints with unspecified source (aka dynamic source), the filters usually only apply to a set of similar webpages (e.g. an endpoint that works for any youtube channel). However, we currently accept any url for dynamic source, which is not ideal if the source isn't expected. To improve it, we can have an optional match_source field where user can specify a regular expression pattern for specifying supported source urls. Then if the provided source doesn't match the pattern, we no longer make the request and report the error nicely back to the user.

@shouya shouya added the feature request New feature or request label Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant