feat(flutter_tool): dump class table during snapshot compilation #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felangel
commented
Nov 26, 2024
felangel
commented
- feat(flutter_tool): dump class table during snapshot compilation
eseidel
reviewed
Nov 26, 2024
| '--deterministic', | ||
| // Shorebird dumps the class table information during snapshot compilation. | ||
| '--print_class_table_link_debug_info_to=${_fileSystem.path.join(outputDir.path, 'class_table.json')}', |
There was a problem hiding this comment.
Will these overwrite each other between phases, or are the phases built to separate directories?
There was a problem hiding this comment.
They'll overwrite each other currently but my thinking was that shouldn't matter because we'll zip and upload them as part of each phase (e.g. when building the release we'll zip and upload the "extra metadata" to the Shorebird backend and pull the relevant metadata down when compiling the patch).
eseidel
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.