New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static fallback to 19% in basket #2608

Open

mitelg opened this issue Sep 20, 2023 · 0 comments · May be fixed by #2757

Contributor

mitelg commented Sep 20, 2023 •

edited

Loading

Instructions for reproduction:

Basic settings > Create a shopping cart discount for customer groups, e.g. 10%.
Create a tax rule for this customer group and define 0%-> Shopping cart discount is still calculated with 19%.

The cause is this query: https://github.com/shopware5/shopware/blob/v5.7.18/engine/Shopware/Core/sBasket.php#L425-L427

If you change this e.g. to (!$tax && $tax != 0) then it also works with 0% tax.

Dominikrt linked a pull request

that will close this issue

fix: customer group discount tax #2757

Draft

4 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment