Merge branch 'sw-26909/adjust-customer-module-data' into 'v5.7.15'

SW-26909 - adjust customer module See merge request shopware/5/product/shopware!913
shopware5 · Sep 8, 2022 · fef1e05 · fef1e05
2 parents 5b45d02 + af5cdbc
commit fef1e05
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/engine/Shopware/Controllers/Backend/Customer.php b/engine/Shopware/Controllers/Backend/Customer.php
@@ -791,6 +791,9 @@ private function getCustomer(int $id): array
             $data['lastLogin'] = new DateTime('@0');
         }
 
+        unset($data['sessionId']);
+        unset($data['hashPassword']);
+
         return $data;
     }
 

diff --git a/tests/Functional/Controllers/Backend/CustomerTest.php b/tests/Functional/Controllers/Backend/CustomerTest.php
@@ -60,6 +60,23 @@ public function setUp(): void
         Shopware()->Plugins()->Backend()->Auth()->setNoAcl();
     }
 
+    public function testSensitiveDataIsNotSend(): void
+    {
+        $customer = $this->createDummyCustomer();
+
+        $params = [
+            'customerID' => $customer->getId(),
+        ];
+        $this->Request()->setMethod('POST')->setPost($params);
+        $this->dispatch('/backend/Customer/getDetail');
+
+        $body = $this->View()->getAssign();
+        static::assertTrue($body['success']);
+        static::assertArrayNotHasKey('hashPassword', $body['data']);
+        static::assertArrayNotHasKey('sessionId', $body['data']);
+        static::assertEquals('[email protected]', $body['data']['email']);
+    }
+
     /**
      * Test saveAction controller action - change payment mean
      *