Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate types and clients to a different location #4

Open
ricardomaraschini opened this issue Feb 11, 2022 · 2 comments
Open

Migrate types and clients to a different location #4

ricardomaraschini opened this issue Feb 11, 2022 · 2 comments
Labels
kind/design Categorizes issue or PR as related to design.

Comments

@ricardomaraschini
Copy link
Contributor

Wouldn't it be good to have the kubernetes types and clients into something like a "shipwright-io/apis" ? If we plan to migrate kubectl-image kubectl plugin to shp client that could be a good idea.

Is there already a centralized place for the shipwright api types/clients ?

@ricardomaraschini ricardomaraschini added the kind/design Categorizes issue or PR as related to design. label Feb 11, 2022
@ricardomaraschini ricardomaraschini changed the title Migrate types to a different location Migrate types and clients to a different location Feb 11, 2022
@otaviof
Copy link
Member

otaviof commented Feb 12, 2022

I like the idea, we will benefit from having all CRDs, code generation scripts, Kubernetes clients, and the discussions surrounding the APIs on the same place 👍 Plus the modules imported on the other projects will be much easier handle.

Lets make sure the initiative is registered for the next community meeting.

@ricardomaraschini
Copy link
Contributor Author

For the record: following a meeting we have agreed that this is not a priority at this moment. As the projects grow we may adopt this but at this stage it is not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design Categorizes issue or PR as related to design.
Projects
None yet
Development

No branches or pull requests

2 participants