Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accuracy and speed results from EVMole benchmark #66

Open
cdump opened this issue Dec 2, 2023 · 2 comments
Open

Accuracy and speed results from EVMole benchmark #66

cdump opened this issue Dec 2, 2023 · 2 comments

Comments

@cdump
Copy link

cdump commented Dec 2, 2023

Hi,
I've added your project to the accuracy and speed benchmark of cdump/evmole

I think you may be interested in that results, to examine errors of whatsabi you can run:

$ sudo apt install git-lfs
$ git clone https://github.com/cdump/evmole 
$ cd evmole/

# you need GNU Make, https://formulae.brew.sh/formula/make - if you are using macos

$ PROVIDERS="etherscan whatsabi" make -C benchmark
$ poetry run python3 benchmark/compare.py --providers etherscan whatsabi --web-listen 0.0.0.0:8080 

# skip PROVIDERS/--providers to compare with other tools, like evm-hound-rs & evmole

Open http://127.0.0.1:8080 after that and you'll see the results:
20231202_10h28m29s_grim

P.S. if you believe I am using your project incorrectly, please feel free to submit a pull request with fixes.

@shazow
Copy link
Owner

shazow commented Dec 13, 2023

Heya, just wanted to follow up, thanks again for tracking this!

I'm mostly focused on proxy stuff right now but I'd love to dive into the false positives/negatives sometime soon too. :)

One suggestion as you're accumulating benchmarks: Would be nice to include which version of the respective library/codebase was benchmarked.

@cdump
Copy link
Author

cdump commented Dec 14, 2023

include version

got it, will add it to the results soon.

btw, in the latest version you can view the errors right in the console without using the browser by running compare.py with --show-errors instead of --web-listen 0.0.0.0:8080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants