Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use more ox #155

Open
shazow opened this issue Nov 15, 2024 · 0 comments
Open

refactor: Use more ox #155

shazow opened this issue Nov 15, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@shazow
Copy link
Owner

shazow commented Nov 15, 2024

  1. keccak

(ox)[https://oxlib.sh/] exposes Hash, so we can get rid of calling import { keccak_256 } from '@noble/hashes/sha3'; directly, so we won't need to worry about the peerDependency.

In general can probably move most of https://github.com/shazow/whatsabi/blob/main/src/utils.ts into using ox instead.

  1. stronger typing

I've been meaning to add more abitype-style types throughout WhatsABI, now it's a bit easier because we can use ox's exposed types too. For example, import type Address from "ox/Address" should get us that.

@shazow shazow added enhancement New feature or request good first issue Good for newcomers labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant