Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notify.js: ReactDOM.render is no longer supported in React 18 #2124

Closed
Entkenntnis opened this issue Feb 21, 2023 · 2 comments · Fixed by #2293
Closed

notify.js: ReactDOM.render is no longer supported in React 18 #2124

Entkenntnis opened this issue Feb 21, 2023 · 2 comments · Fixed by #2293
Labels
question Further information is requested

Comments

@Entkenntnis
Copy link
Member

happens if notification is triggered

investigate if library can be upgrades
@elbotho
Copy link
Member

elbotho commented Feb 21, 2023 •
edited
Loading

created upstream issues:
jesusoterogomez/react-notify-toast#85
jesusoterogomez/react-notify-toast#86

@Entkenntnis Entkenntnis added question Further information is requested and removed refactoring labels Mar 1, 2023
@Entkenntnis
Copy link
Member Author

last updated 4 years ago, I don't see much hope this will be fixed upstream.

  • ReactDOM.render only affects the notification, this will have no negative impact on other parts of the code base ... it's probably safe it ignore for now
  • other options are forking / copying / replacing: more involved and I don't thing it's valuabe at the moment

@elbotho I would recommand that we move that into backlog and close this issue for now, as it's not actionable

@Entkenntnis Entkenntnis reopened this Apr 12, 2023
@Entkenntnis Entkenntnis linked a pull request Apr 12, 2023 that will close this issue
upgrade react notfy toast to react 18 #2293
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

upgrade react notfy toast to react 18 serlo/frontend
2 participants
@elbotho @Entkenntnis