Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to use executables from local container instead of local system #6

Open
serhei opened this issue Dec 11, 2019 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@serhei
Copy link
Owner

serhei commented Dec 11, 2019

This would allow oc-inject to use executables that match the distribution within the container image (instead of hoping the local development environment's executables will work within the container environment).

Requires assembling a suite of images for different OpenShift environments, along the lines of support-tools https://access.redhat.com/containers/#/registry.access.redhat.com/rhel8/support-tools -- could be done by collecting a set of Dockerfiles and building them locally with Podman, or by uploading images to a registry.

@serhei serhei added this to the v1.0 milestone Dec 11, 2019
@serhei serhei added the enhancement New feature or request label Dec 11, 2019
@serhei
Copy link
Owner Author

serhei commented Feb 7, 2020

Brainstorming how this feature should ideally work. The workflow could actually be as follows, e.g. for Java support:

  • Take the same container image as what's running in OpenShift.
  • Use as the base image for a local container build e.g. FROM my-container-image; RUN yum install java-1.8.0-openjdk-devel -> producing my-debug-image
  • oc-inject --from-podman=my-debug-image -it my-container -- jstack 1 (oc-inject uses something like podman run to run ldd in the container image, then podman mount to extract the files)

If these steps are well-documented, it would reduce the need for do-everything 'support-tools' type images. Perhaps the first two steps could be automated with a separate command, or turned into an oc-inject command line option:

oc-inject --from-openshift=my-container+java-1.8.0-openjdk -it my-container -- jstack 1
oc-inject -it my-container+java-1.8.0-openjdk -- jstack 1

@serhei serhei modified the milestones: v1.0, v0.8 Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant