Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC with Github #1618

Closed
Alex-Giaquinto opened this issue Nov 8, 2023 · 4 comments
Closed

OIDC with Github #1618

Alex-Giaquinto opened this issue Nov 8, 2023 · 4 comments

Comments

@Alex-Giaquinto
Copy link

Not sure if this is the right place for this, but does anyone have a working example of how to set up OIDC authentication with Github? I saw that it is working on the demo provided in the README, but having trouble getting it up on my end. I just upgraded to version 2.9.37, the button appears when I add the OIDC config to the config.js according to the documentation. But when I click the button the page just basically refreshes and I am back on the login screen. If anyone has an idea it would be super helpful!!! Thank you!

@hmoffatt
Copy link

Have you configured Semaphore to use a path in the web root by any chance? ie xyz.com/semaphore instead of just xyz.com?

@Alex-Giaquinto
Copy link
Author

@hmoffatt I don't believe so. Is there any specific snippet of the config you would like to see? Maybe can help lead you in the right direction?

@hmoffatt
Copy link

hmoffatt commented Nov 13, 2023

I only asked because I noticed that OpenID Connect login is broken when you use a path component. I fixed this in #1572

I have not tried using OIDC with GitHub so I don't think I can offer any help otherwise.

@fiftin
Copy link
Collaborator

fiftin commented Nov 17, 2023

Yes, I have:

        "oidc_providers": {

                "github": {
                        "icon": "github",
                        "display_name": "Sign in with GitHub",
                        "client_id": "***",
                        "client_secret": "***",
                        "redirect_url": "https://cloud.ansible-semaphore.com/api/auth/oidc/github/redirect",
                        "endpoint": {
                                "auth": "https://github.com/login/oauth/authorize",
                                "token": "https://github.com/login/oauth/access_token",
                                "userinfo": "https://api.github.com/user"
                        },
                        "scopes": ["read:user", "user:email"]
                },

        }

@semaphoreui semaphoreui locked and limited conversation to collaborators Nov 17, 2023
@fiftin fiftin converted this issue into discussion #1631 Nov 17, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants