Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does "Is using secure protocols" in "Create new lobby" exist #30

Open
Bios-Marcel opened this issue Mar 9, 2021 · 5 comments
Open

Comments

@Bios-Marcel
Copy link
Member

Bios-Marcel commented Mar 9, 2021

The user should not have the choice to disable https if the server supports it. Was there a reason for this decision? I am assuming the green box in the top indicates whether the instance is online? Doesn't this mean we can also check whether it supports HTTPs the same way?

We've got the same box in the "Find lobby" view. What effect does it have there?

@BigETI
Copy link
Member

BigETI commented Mar 9, 2021

If I run a local instance for testing, it does not support HTTPS, therefore this option is very useful if I want to connect to an instance that does not support HTTPS.

@Bios-Marcel
Copy link
Member Author

But we can just detect it automatically, right? There's no need for the checkbox. Just try "HTTPS" first, if it doesn't work, try "HTTP". Makes the UI simpler and less confusing.

@BigETI
Copy link
Member

BigETI commented Mar 19, 2021

I am not a fan of implicitly falling back to insecure methods without the user knowing that. Maybe we can warn the user that the connection is not secure at all.

@Bios-Marcel
Copy link
Member Author

Can't we just put a lock next to the address, just like browsers do it?

@BigETI
Copy link
Member

BigETI commented Mar 27, 2021

Well, maybe...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants