Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis build failing due to scikit-learn update #386

Open
neontty opened this issue May 29, 2020 · 1 comment · May be fixed by #387
Open

travis build failing due to scikit-learn update #386

neontty opened this issue May 29, 2020 · 1 comment · May be fixed by #387

Comments

@neontty
Copy link
Collaborator

neontty commented May 29, 2020

requirements defines: scikit-learn>=0.17

scikit 0.23.1 only supports python3.6+

possible fix: update test matrix in travis_ci.yml and ci-scripts to use scikit-learn==0.22

@neontty neontty linked a pull request May 29, 2020 that will close this issue
@neontty
Copy link
Collaborator Author

neontty commented Jun 6, 2020

I need some direction on how we want to fix the travis_ci:

here are some notes about the build chain:

in the travis build we set several options for forcing package versions in our conda environment (cython, scipy, numpy). However, these all get overridden by pip during the python setup.py develop call, which installs new versions over top of what we have specified in order to satisfy our requirements.txt . That is why we are installing scikit-learn==0.23.1 and failing to install on the python3.5 version.

I'm guessing we just want to test that hdbscan runs across the different python3.x versions with whatever versions of the dependencies that conda thinks is best.

Also; Due to the bug in numpy we bumped our numpy>=1.16.0 #272 , which requires python3.6+ . This invalidates the second test in the travis matrix.

Suggestions:

  • allow conda to figure out dependency package versions instead of passing them in manually through travis conda create --file hdbscan/requirements.txt
  • move the second test case in travis to python3.6 OR revisit requirements.txt to make minimum versions lower that can actually run on python3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant