-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does BorutaPy work with cuML RandomForestClassifier? #99
Comments
At the moment boruta tries to set the random state to all estimators. cuML's RF classifier do not have this parameter. You can try a fix like with lightgbm. Something like this before the else part could help you.
Lines 340 to 344 in f2f1e3c
|
Thanks @Wuuzzaa. I made the adjustment you recommended but now I'm receiving this error: "ValueError: Only methods with feature_importance_ attribute are currently supported in BorutaPy." Any recommendations on this issue? |
Seems like the implementation from cuML´s random forest differs quiete a lot from sklearns. I just took a look at the docu and do not found something similar to the feature importance. Some kind of feature importance is necessary for boruta to determine which features are useful. I think there is no easy way to work around this issue. |
@curtisraymond and @Wuuzzaa Hi ... any solution for this? I'm going through the same problem. However, I'm getting a different error: "integer required" ErrorTypeError Traceback (most recent call last) TypeError: an integer is required ValueError: Please check your X and y variable. The providedestimator cannot be fitted to your data. |
My blind guess would be an error on your y data? y must be integers. Did you check your X and y for compatible Data types. |
Hi @Wuuzzaa .. Thank you for the quick reply. y are integers. It works fine when I use sklearn's RF classifier. But I get this error when I use cuML's RF classifier. My guess is that there might be an incompatibility between cuML and BorutaPy |
BorutaPy was never planned to be used within cuML. Seems like it still do not work. Like beckernick mentioned there is still an open Issue on cuML for the implementation of the Feature Importance which is needed for boruta to work. |
Thanks for linking that issue @Wuuzzaa ! @lindeberg25 , we'd love to learn more about your use case and performance impact of using cuML's Random Forest vs. scikit-learn's RF. Let's continue the discussion on the linked issue. |
I tried running BorutaPy using cuML's RF classifier but I receive the following error: "ValueError: Bad param 'random_state' passed to set_params". Does BorutaPy work with cuML RandomForestClassifier?
Ideally I'd like to speed things up using a classifier that works well with gpu.
The text was updated successfully, but these errors were encountered: