You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not strictly a bug, but it's current behaviour is not ideal.
Right now, the data are not shuffled — and hitting Regenerate does nothing. So you always have the same test data points with these datasets.
Current method: slice 2n positive and n negative samples from the beginning of the array for train, and 2n +ve and n -ve from the end of the array (hence the negative slices in the Test function). It's not a great way to do it. It also means you can't shuffle the data.
The problem is that there is two separate functions and they don't know about each other. So how does the Test generator know which samples were used for Train? I think the Train generator has to pass back the indices of the Test set, which we can then pass to the Test generator.
Not strictly a bug, but it's current behaviour is not ideal.
Right now, the data are not shuffled — and hitting Regenerate does nothing. So you always have the same test data points with these datasets.
Current method: slice 2n positive and n negative samples from the beginning of the array for train, and 2n +ve and n -ve from the end of the array (hence the negative slices in the Test function). It's not a great way to do it. It also means you can't shuffle the data.
The problem is that there is two separate functions and they don't know about each other. So how does the Test generator know which samples were used for Train? I think the Train generator has to pass back the indices of the Test set, which we can then pass to the Test generator.
This combines and closes agilescientific#15 and agilescientific#23.
The text was updated successfully, but these errors were encountered: