feat: Automate HPLIP driver and plugin installation #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you build an image for arm64. My amd64 machine is currently broken (motherboard fried due to lightening). |
|
@ameer1234567890 i haven't tested the arm build but it is now published on |
|
Sorry, I was wrong. It should be arm, not arm64 |
|
@ameer1234567890 ok, ive published arm/v7 (same as scanservjs) now. |
|
I tested it and my HP scanner is detected perfectly. However, unlike the original scanservjs docker image, my Canon scanner is not detected now. |
|
Successfully tested with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #701 #724
This abides by the "no additional backends in docker" intention because it does not install anything unless the user explicitly sets either
HP_AIOorHP_PLUGINenvs.HP_AIO=trueto install onlylibsane-hpaiodependency at container startHP_PLUGIN=trueto installlibsane-hpaioand HPLIP binary plugin at container startThe scripts also check for install status of the dependency and plugin so they will only run if not already installed.
Additionally, the script that installs the plugin,
hplip.sh, is distribution agnostic so it can be used in any local install of scanservjs as long as the OS has the equivalent hpaio driver installed (which also installshp-plugin).A docker image is built with these changes at
foxxmd/scanservjs:latest