Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #10

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Update README.md #10

merged 2 commits into from
Jun 14, 2024

Conversation

h-wata
Copy link
Contributor

@h-wata h-wata commented Jun 10, 2024

@h-wata h-wata marked this pull request as draft June 10, 2024 09:58
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 10, 2024
Copy link

Title

Update README.md


PR Type

documentation


Description

  • rest_kachaka_api.pyconnect_openrmf_by_zenoh.pyの使用方法をREADMEに追加
  • config.yamlの設定方法とその例をREADMEに追加
  • Open-RMFサーバーとの通信方法を詳細に記述

Changes walkthrough 📝

Relevant files
Documentation
README.md
スクリプト使用方法と設定の詳細をREADMEに追加                                                               

README.md

  • 追加されたスクリプトの使用方法を説明
  • config.yamlの設定方法を説明
  • Open-RMFサーバーとの通信方法を詳細に記述
  • +28/-0   

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review [1-5]

    1

    🧪 Relevant tests

    No

    🔒 Security concerns

    No

    ⚡ Key issues to review

    None

    Copy link

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Best practice
    YAMLのインデントを2スペースに統一します。

    config.yaml の例において、YAMLのインデントが正しくないと誤解される可能性があるため、インデントを2スペースに統一します。

    README.md [122-125]

    +```yaml
    +method_mapping:
    +  dock: return_home
    +```
     
    -
    Suggestion importance[1-10]: 9

    Why: Correcting the YAML indentation to a consistent 2-space format prevents potential misconfigurations and ensures clarity, which is crucial for proper script execution.

    9
    Enhancement
    NAT traversal の意味を補足説明として追加します。

    connect_openrmf_by_zenoh.py の説明において、「NAT
    traversal」が何を意味するのかを簡単に説明すると、ユーザーがより理解しやすくなります。例えば、「NAT traversal
    (ネットワークアドレス変換の通過)」のように補足説明を追加します。

    README.md [31]

    -- Use this script when communicating with an Open-RMF server via Zenoh router, requiring NAT traversal.
    +- Use this script when communicating with an Open-RMF server via Zenoh router, requiring NAT traversal (ネットワークアドレス変換の通過).
     
    Suggestion importance[1-10]: 8

    Why: Adding a brief explanation of "NAT traversal" makes the documentation more accessible to users who may not be familiar with the term, enhancing clarity and usability.

    8
    スクリプトの使用例を追加します。

    「## Usage of Scripts」セクションにおいて、スクリプトの使用例を追加すると、ユーザーが具体的な使い方を理解しやすくなります。

    README.md [23-33]

     1. `rest_kachaka_api.py`:
     ...
    +Example:
    +```bash
    +python rest_kachaka_api.py
    +```
     1. `connect_openrmf_by_zenoh.py`:
    +...
    +Example:
    +```bash
    +python connect_openrmf_by_zenoh.py
    +```
     
    Suggestion importance[1-10]: 8

    Why: Adding usage examples for the scripts provides clear guidance on how to run them, which is very helpful for users, especially those who are new to the project.

    8
    スクリプトのファイル名をコードブロックで囲んで強調します。

    rest_kachaka_api.pyconnect_openrmf_by_zenoh.py
    の説明において、スクリプトのファイル名をコードブロックで囲むと、視覚的に強調されて読みやすくなります。

    README.md [23-29]

    -1. rest_kachaka_api.py:
    +1. `rest_kachaka_api.py`:
     ...
    -1. connect_openrmf_by_zenoh.py:
    +1. `connect_openrmf_by_zenoh.py`:
     
    Suggestion importance[1-10]: 7

    Why: Using code blocks to highlight script filenames improves readability and helps users quickly identify the scripts, enhancing the overall user experience.

    7

    @h-wata h-wata requested a review from MikhailBertrand June 14, 2024 09:02
    @h-wata h-wata marked this pull request as ready for review June 14, 2024 09:02
    @MikhailBertrand MikhailBertrand merged commit d251c70 into main Jun 14, 2024
    @MikhailBertrand MikhailBertrand deleted the feature/update_readme branch June 14, 2024 09:07
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    documentation Improvements or additions to documentation Review effort [1-5]: 1
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    NAT超えする場合としない場合のスクリプトの使い分けについて説明する
    2 participants