RFC Blogpost for indented syntax #1260
Open
+130
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sass-lang ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jgerigmeyer
reviewed
Nov 26, 2024
Comment on lines
54
to
66
| ```sass | ||
| @each $item in ¹ | ||
| 1 2 3 | ||
| .item-#{ ² | ||
| $item | ||
| } | ||
| content: $item * ³ | ||
| 10 | ||
| ``` | ||
|
|
||
| 1. A statement can't end after the word "in" in an `@each` statement. | ||
| 2. A statement can't end inside the curly braces in an interpolation. | ||
| 3. A statement can't end after a multiplication operator. |
There was a problem hiding this comment.
I think these references might be easier to parse if they used line numbers instead of superscript. Or I'm not sure if there's a better way to make it clear that they're not part of the code example?
There was a problem hiding this comment.
Line numbers made it harder to follow, I think.
I'll push a version with inline comments-
Here's the original-
Comment on lines
+48
to
+50
| linebreak is treated as whitespace. This means that if the parser can't tell | ||
| whether or not a linebreak is intended to end a statement, it will end the | ||
| statement. |
There was a problem hiding this comment.
Would it be helpful to also include a code example showing the "parser can't tell" path?
|
@nex3 This is ready for review. It currently has today's date (11-27) but given the holiday, I could update that to next week if you'd prefer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.