Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Removing scoped filter while discovering packages #34

Merged
merged 3 commits into from
Oct 6, 2023
Merged

[bugfix] Removing scoped filter while discovering packages #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4d371b
Removed the filterInputsBy package line, which prevents scanning cust…
Tushar-Naik Oct 6, 2023
ef88ee5
Bumping up version
Tushar-Naik Oct 6, 2023
2f6220f
Updated release notes
Tushar-Naik Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Use the following dependency in your code.
<dependency>
<groupId>io.appform.hope</groupId>
<artifactId>hope-lang</artifactId>
<version>2.0.3</version>
<version>2.0.4</version>
</dependency>
```

Expand Down
5 changes: 4 additions & 1 deletion ReleaseNotes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
# 2.0.4
- Bugfix: Removed the filterInputsBy package line, which prevents scanning custom packages that are registered on hopebuilder

# 2.0.3
- Bugfix in `pointer.exists`
- Version bump for vulnerable components
-

# 2.0.2
- Added equals and hashCode to value types

Expand Down
2 changes: 1 addition & 1 deletion hope-core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<parent>
<artifactId>hope</artifactId>
<groupId>io.appform.hope</groupId>
<version>2.0.3</version>
<version>2.0.4</version>
</parent>
<modelVersion>4.0.0</modelVersion>

Expand Down
3 changes: 1 addition & 2 deletions hope-core/src/main/java/io/appform/hope/core/functions/FunctionRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@ public synchronized void discover(List<String> packages) {
Reflections reflections = new Reflections(
new ConfigurationBuilder()
.setUrls(packageUrls)
.setScanners(new SubTypesScanner(), new TypeAnnotationsScanner())
.filterInputsBy(new FilterBuilder().includePackage("io.appform.hope.core.functions.impl")));
.setScanners(new SubTypesScanner(), new TypeAnnotationsScanner()));
log.debug("Type scanning complete");
final Set<Class<? extends HopeFunction>> classes = reflections.getSubTypesOf(HopeFunction.class);
classes
Expand Down
2 changes: 1 addition & 1 deletion hope-lang/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<parent>
<artifactId>hope</artifactId>
<groupId>io.appform.hope</groupId>
<version>2.0.3</version>
<version>2.0.4</version>
</parent>
<modelVersion>4.0.0</modelVersion>

Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<groupId>io.appform.hope</groupId>
<artifactId>hope</artifactId>
<packaging>pom</packaging>
<version>2.0.3</version>
<version>2.0.4</version>

<name>Hope</name>
<url>https://github.com/santanusinha/hope</url>
Expand Down
Loading