Merge pull request #34 from Tushar-Naik/master-v1

[bugfix] Removing scoped filter while discovering packages
santanusinha · Oct 6, 2023 · fef0301 · fef0301
2 parents 9c1efe6 + 2f6220f
commit fef0301
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -20,7 +20,7 @@ Use the following dependency in your code.
     <dependency>
         <groupId>io.appform.hope</groupId>
         <artifactId>hope-lang</artifactId>
-        <version>2.0.3</version>
+        <version>2.0.4</version>
     </dependency>
 ```
 

diff --git a/ReleaseNotes.md b/ReleaseNotes.md
@@ -1,7 +1,10 @@
+# 2.0.4
+- Bugfix: Removed the filterInputsBy package line, which prevents scanning custom packages that are registered on hopebuilder
+
 # 2.0.3
 - Bugfix in `pointer.exists`
 - Version bump for vulnerable components
-- 
+
 # 2.0.2
 - Added equals and hashCode to value types
 

diff --git a/hope-core/pom.xml b/hope-core/pom.xml
@@ -5,7 +5,7 @@
     <parent>
         <artifactId>hope</artifactId>
         <groupId>io.appform.hope</groupId>
-        <version>2.0.3</version>
+        <version>2.0.4</version>
     </parent>
     <modelVersion>4.0.0</modelVersion>
 

diff --git a/hope-core/src/main/java/io/appform/hope/core/functions/FunctionRegistry.java b/hope-core/src/main/java/io/appform/hope/core/functions/FunctionRegistry.java
@@ -75,8 +75,7 @@ public synchronized void discover(List<String> packages) {
         Reflections reflections = new Reflections(
                 new ConfigurationBuilder()
                         .setUrls(packageUrls)
-                        .setScanners(new SubTypesScanner(), new TypeAnnotationsScanner())
-                        .filterInputsBy(new FilterBuilder().includePackage("io.appform.hope.core.functions.impl")));
+                        .setScanners(new SubTypesScanner(), new TypeAnnotationsScanner()));
         log.debug("Type scanning complete");
         final Set<Class<? extends HopeFunction>> classes = reflections.getSubTypesOf(HopeFunction.class);
         classes

diff --git a/hope-lang/pom.xml b/hope-lang/pom.xml
@@ -5,7 +5,7 @@
     <parent>
         <artifactId>hope</artifactId>
         <groupId>io.appform.hope</groupId>
-        <version>2.0.3</version>
+        <version>2.0.4</version>
     </parent>
     <modelVersion>4.0.0</modelVersion>
 

diff --git a/pom.xml b/pom.xml
@@ -7,7 +7,7 @@
     <groupId>io.appform.hope</groupId>
     <artifactId>hope</artifactId>
     <packaging>pom</packaging>
-    <version>2.0.3</version>
+    <version>2.0.4</version>
 
     <name>Hope</name>
     <url>https://github.com/santanusinha/hope</url>