Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems loading old ProtocolDatas with new develop #498

Open
pcwysoc opened this issue Oct 17, 2024 · 2 comments
Open

Problems loading old ProtocolDatas with new develop #498

pcwysoc opened this issue Oct 17, 2024 · 2 comments
Assignees
Labels
bug A bug or regression

Comments

@pcwysoc
Copy link

pcwysoc commented Oct 17, 2024

Describe the bug
The new version of develop introduces issues loading ProtocolDatas and associated classes from older pyGSTi versions due to circuit.py changes. I ran into this issue with pickle originally, but I am now observing it mainly with the from_dir method. Here's a demo notebook:

CircuitLoadingBug.ipynb.zip

@pcwysoc pcwysoc added the bug A bug or regression label Oct 17, 2024
@coreyostrove
Copy link
Contributor

Thanks for the report and the notebook, @pcwysoc. I was aware of the pickle issue, and this has been fixed on #496. I am having some trouble reproducing the issue with the protocol data objects though. Could you provide a pair of specific commits for the data object generation and read-in which reproduces the issue?

@pcwysoc
Copy link
Author

pcwysoc commented Nov 25, 2024

Hi @coreyostrove, this may have been a branch specific issue. I will follow up if it appears to be a larger problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug or regression
Projects
None yet
Development

No branches or pull requests

3 participants