Allow custom error message resolvers

[ShaneYu]

This entire project is great, especially the level of customization, however I've found a place of extension and want to raise a feature/enhancement issue.

I am happy to fork this repository, make the changes and then request a pull back in. 😄

Currently, when a error message is shown via the simple or tooltip message services, they get the message from the validation service by called 'getErrorMessage' which then internally calls 'resolveMessage'. At this present time, resolveMessage will just attempt to get the message from the global config of messages, however it would be great to be able to have a custom message resolve service that could be called to. This would mean we could create a message resolve service that, for example, uses angular translate to get the messages from translation files instead, of from a reference data service that fetches data from a web api and caches etc; there are many possibilities.

I propose we allow the ability for developers to create custom resolvers for the messages and just have a default one that falls back to the current config.

Is this a feature you would be happy to merge in should someone code it?

[sagrawal31]

Thanks @ShaneYu. Glad you found this helpful! The new feature you suggested is amazing. I'm running busy from quite a few months otherwise I would like to implement this but yes, of course, I'll be happy to merge in others contributions.

[ShaneYu]

Thanks for the quick reply @sagrawal14.

I've implemented support for filters on the messages already on my machine, I was thinking to commit and request a merge on that also. It allows the developer to specify one or more angular filters to apply to messages prior to resolving/returning them; I will try to commit and request a pull-request by lunch time.

Then I will look into implementing this feature.

[sagrawal31]

Sure. Thanks

…

On Thu, 12 Jan 2017 at 1:56 PM, Shane Yu ***@***.***> wrote: Thanks for the quick reply @sagrawal14 <https://github.com/sagrawal14>. I've implemented support for filters on the messages already on my machine, I was thinking to commit and request a merge on that also. It allows the developer to specify one or more angular filters to apply to messages prior to resolving/returning them; I will try to commit and request a pull-request by lunch time. Then I will look into implementing this feature. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABuI4j3Z4sOc8mDOkm_kOJl8urXwyke-ks5rReO4gaJpZM4Lhb12> .