Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error on conflicting #[wasm_bindgen] options #4272

Open
RunDevelopment opened this issue Nov 14, 2024 · 0 comments
Open

Error on conflicting #[wasm_bindgen] options #4272

RunDevelopment opened this issue Nov 14, 2024 · 0 comments
Labels
breaking-change Tracking breaking changes for the next major version bump (if ever) bug

Comments

@RunDevelopment
Copy link
Contributor

Motivation

Right now, #[wasm_bindgen(getter, setter)] is valid and will be interpreted as a setter. The getter option will be ignored with no warning or error.

This also affects indexing_getter, indexing_getter, and indexing_deleter.

Solution

Emit a warning about conflicting options for now, and make it a hard error in the next major version.
@daxpedda daxpedda added the breaking-change Tracking breaking changes for the next major version bump (if ever) label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change Tracking breaking changes for the next major version bump (if ever) bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daxpedda @RunDevelopment