Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc 1.83 lexing regression in the 2015 edition: 'r#x'y #133479

Open
mattheww opened this issue Nov 25, 2024 · 2 comments · May be fixed by #133482
Open

rustc 1.83 lexing regression in the 2015 edition: 'r#x'y #133479

mattheww opened this issue Nov 25, 2024 · 2 comments · May be fixed by #133482
Labels
A-parser Area: The parsing of Rust source code to an AST C-bug Category: This is a bug. P-medium Medium priority regression-untriaged Untriaged performance or correctness regression.

Comments

@mattheww
Copy link
Contributor

rustc 1.82 accepts forms like 'r#x'y in the 2015 edition, but rustc 1.83 (beta) rejects them.

As I understand it, #126452 wasn't intended to have any effect on the 2015 edition.

playground

macro_rules! lexes {($($_:tt)*) => {}}

fn main() {
    lexes!('r#x'y);
}

I think this is fallout from the beta-backport of #132341.

@mattheww mattheww added C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. labels Nov 25, 2024
@rustbot rustbot added I-prioritize Issue: Indicates that prioritization has been requested for this issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Nov 25, 2024
@compiler-errors
Copy link
Member

I'm tempted to say that this is a purely theoretical regression, and we should perhaps fix it in 1.84 but it's possibly a bit too late for 1.83? Especially because I'm not certain how to prepare a fix for this other than perhaps reverting raw lifetime functionality altogether.

@saethlin saethlin removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Nov 26, 2024
@compiler-errors compiler-errors added the A-parser Area: The parsing of Rust source code to an AST label Nov 26, 2024
@apiraino
Copy link
Contributor

WG-prioritization assigning priority (Zulip discussion).

@rustbot label -I-prioritize +P-medium

@rustbot rustbot added P-medium Medium priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-parser Area: The parsing of Rust source code to an AST C-bug Category: This is a bug. P-medium Medium priority regression-untriaged Untriaged performance or correctness regression.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants