Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bindings for custom crossover with example #115

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Add bindings for custom crossover with example #115

merged 1 commit into from
Jan 22, 2024

Conversation

rchildre3
Copy link
Contributor

  • Expose LLVMFuzzerCustomCrossOver through fuzz_crossover macro.
  • example_crossover uses fuzz_mutator & fuzz_crossover

Closes #101

fitzgen
fitzgen reviewed Dec 11, 2023
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One request below before we merge this.

src/lib.rs Outdated Show resolved Hide resolved
@rchildre3
Copy link
Contributor Author

Changed the interface slightly to be more in line with that of fuzz_target! (i.e. omitting the size parameter as the slice encompasses the slice length)

fitzgen
fitzgen reviewed Jan 22, 2024
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM, just one minor nitpick before we can merge.

example_crossover/fuzz/artifacts/boom/crash-6f37ac2111469380f475f6c307a915f5917fed6b Outdated Show resolved Hide resolved
Add bindings for custom crossover with example
c773bcf 
* Expose `LLVMFuzzerCustomCrossOver` through `fuzz_crossover` macro.
* `example_crossover` uses `fuzz_mutator` & `fuzz_crossover`
@rchildre3
Copy link
Contributor Author

Nit fixed

fitzgen
fitzgen approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fitzgen fitzgen merged commit 9b8c0a7 into rust-fuzz:main Jan 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Expose LLVMFuzzerCustomCrossOver
2 participants
@rchildre3 @fitzgen