confusion with directory documentation

[x37v]

A couple notes/questions:

1. open_root_dir and open_dir both indicate: Open a directory. You can then read the directory entries in a random order using get_directory_entry. But get_directory_entry doesn't exist in the code AFAIK. I see find_directory_entry and iterate_dir so I assume this must just be left over cruft?

2. open_root_dir and open_dir return a Directory, the docs for close_dir indicate:
   Close a directory. You cannot perform operations on an open directory and so must close it if you want to do something with it. but close_dir consumes a directory so how do you use it after its closed? For instance, how would you supply a directory to open_file_in_dir ?

[x37v]

looking at this example.. i'm guessing the close_dir documentation is wrong?

embedded-sdmmc-rs/examples/test_mount.rs

Lines 129 to 144 in ed1b7ea

	let root_dir = controller.open_root_dir(&volume).unwrap();
	println!("\tListing root directory:");
	controller
	.iterate_dir(&volume, &root_dir, |x| {
	println!("\t\tFound: {:?}", x);
	})
	.unwrap();
	println!("\tFinding {}...", FILE_TO_PRINT);
	println!(
	"\tFound {}?: {:?}",
	FILE_TO_PRINT,
	controller.find_directory_entry(&volume, &root_dir, FILE_TO_PRINT)
	);
	let mut f = controller
	.open_file_in_dir(&mut volume, &root_dir, FILE_TO_PRINT, Mode::ReadOnly)
	.unwrap();

[x37v]

we resolved 1 with that PR but 2 .. the documentation about close_dir is still confusing

[thejpster]

I think 2. means you can’t create a file in a directory when the directory is open? Because then you could get iterator invalidation if the entries moved around. But I agree the wording is awful.