Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support different codepages #113

Open
thejpster opened this issue Dec 19, 2023 · 1 comment
Open

Support different codepages #113

thejpster opened this issue Dec 19, 2023 · 1 comment

Comments

@thejpster
Copy link
Member

Currently we assume that short file names contain valid UTF-8, which is not always true.

We should have some kind of generic type param for a codepage convertor which can do fn convert_from(byte: u8) -> char and fn convert_to(ch: char) -> Result<u8, EncodingError>. Users could either stuff in a CodePage 437 or ISO-8859-1 converter, or something that can dynamically switch code page.

If you have multiple partitions with different codepages on the same disk, we probably can't help you.
@thejpster
Copy link
Member Author

Technically we assume short names contain valid ISO-8859-1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thejpster