unknown flag: --no-recreate when "Dev containers: Reopen in Container" on VSCode

[sugilog]

Describe the bug

"Dev containers: Reopen in Container" on VSCode to start devcontainer, then devcontainer failed to start.

Steps to reproduce

• open VSCode on your mac.
• configure using finch instead of docker/docker-compose in VSCode Settings.
• open folder some folder contains .devcontainer configuration.
• call "Dev containers: Reopen in Container" using VSCode Command Pallete. (without existing devcontainer)
• call "Dev containers: Reopen Folder Locally" to go back to host machine (and container will be exit)
• call "Dev containers: Reopen in Container" using VSCode Command Pallete.

Expected behavior

• supporting --no-recreate docker flag.
• available to start devcontainer by finch.

Screenshots or logs
If applicable, add screenshots or logs to help explain your problem.

[2024-11-20T05:16:13.366Z] Start: Run: finch compose --project-name PROJECTNAME -f /Users/sugilog/gitrepo/.devcontainer/docker-compose.yml -f /Users/sugilog/Library/Application Support/Code/User/globalStorage/ms-vscode-remote.remote-containers/data/docker-compose/docker-compose.devcontainer.build-1732079773218.yml -f /Users/sugilog/Library/Application Support/Code/User/globalStorage/ms-vscode-remote.remote-containers/data/docker-compose/docker-compose.devcontainer.containerFeatures-1732079773365-4271669d-7b29-46d2-a2a2-caf683fc3eb1.yml up -d --no-recreate
[2024-11-20T05:16:13.503Z] FATA[0000] unknown flag: --no-recreate                  
[2024-11-20T05:16:13.506Z] Stop (140 ms): Run: finch compose --project-name PROJECTNAME -f /Users/sugilog/gitrepo/.devcontainer/docker-compose.yml -f /Users/sugilog/Library/Application Support/Code/User/globalStorage/ms-vscode-remote.remote-containers/data/docker-compose/docker-compose.devcontainer.build-1732079773218.yml -f /Users/sugilog/Library/Application Support/Code/User/globalStorage/ms-vscode-remote.remote-containers/data/docker-compose/docker-compose.devcontainer.containerFeatures-1732079773365-4271669d-7b29-46d2-a2a2-caf683fc3eb1.yml up -d --no-recreate
[2024-11-20T05:16:13.507Z] Error: Command failed: finch compose --project-name PROJECTNAME -f /Users/sugilog/gitrepo/.devcontainer/docker-compose.yml -f /Users/sugilog/Library/Application Support/Code/User/globalStorage/ms-vscode-remote.remote-containers/data/docker-compose/docker-compose.devcontainer.build-1732079773218.yml -f /Users/sugilog/Library/Application Support/Code/User/globalStorage/ms-vscode-remote.remote-containers/data/docker-compose/docker-compose.devcontainer.containerFeatures-1732079773365-4271669d-7b29-46d2-a2a2-caf683fc3eb1.yml up -d --no-recreate

Additional context

% finch --version
finch version v1.4.1

% docker --version
finch version v1.4.1

% code --version
1.95.3
f1a4fb101478ce6ec82fe9627c43efbf9e98c813
arm64

To help debug the issue as quickly as possible, we recommend generating a support bundle with finch support-bundle generate and attaching it to this issue. This packages all Finch-related configs and logs into one file.

finch-support-20241120142615.zip

[pendo324]

I've created a PR to add these commands to nerdctl: containerd/nerdctl#3687

I think dev container behavior should be the same with or without this argument, so we may remove it from the list of arguments temporarily as a workaround

[sugilog]

@pendo324 Thank you for your quick response!