Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable build --ssh test on Windows #106

Merged
merged 1 commit into from
Jan 5, 2024
Merged

fix: disable build --ssh test on Windows #106

merged 1 commit into from
Jan 5, 2024

Conversation

pendo324
Copy link
Member

@pendo324 pendo324 commented Jan 5, 2024

Issue #, if available: runfinch/finch#750, runfinch/finch#649

Description of changes:

  • Disable build --ssh test when running on Windows

Testing done:

  • Ran test suite on Windows machine, and it skipped as expected
  [SKIPPED] non-functional on Windows, see https://github.com/runfinch/finch/issues/750
  In [It] at: C:/Users/Administrator/Code/common-tests/tests/build.go:131 @ 01/05/24 20:18:38.223
------------------------------
[SynchronizedAfterSuite]
C:/Users/Administrator/Code/common-tests/run/run_test.go:36
  ef5e5b2ec9fd42f39e6c3a3daac04488b0d7c434446b18eaf4c7c7b6e9cc4ea0
  ef5e5b2ec9fd42f39e6c3a3daac04488b0d7c434446b18eaf4c7c7b6e9cc4ea0
  0a182cb82c93
  Untagged: public.ecr.aws/docker/library/registry:latest@sha256:0a182cb82c93939407967d6d71d6caf11dcef0e5689c6afe2d60518e3b34ab86
  Deleted: sha256:9fe9a137fd002363ac64f5af66146702432b638a83ee0c5b620c40a9e433e813
  Deleted: sha256:d9bce47b357e434a4b294543f1f58cf3113de1d5356dfcb0c67fad2af92f8633
  Deleted: sha256:afcdb1715fb302c8cefa6e90a55c096e13a8d49faee6daaf7745dc0f95f9e90d
  Deleted: sha256:9f383ae4f64d95caaff5c106cf502c1a6f65617a4de01f2cad10353c0e825f5c
  Deleted: sha256:645ddea727356ff8ceb7f90d5ac0aee83bff1ac1ddae1f964228c3051ea50f50
[SynchronizedAfterSuite] PASSED [3.579 seconds]
------------------------------

Ran 0 of 1 Specs in 25.101 seconds
SUCCESS! -- 0 Passed | 0 Failed | 0 Pending | 1 Skipped
  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pendo324 pendo324 requested a review from vsiravar January 5, 2024 20:20
@pendo324 pendo324 self-assigned this Jan 5, 2024
@pendo324 pendo324 merged commit e7fe1eb into runfinch:main Jan 5, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Jan 5, 2024
Merged
pendo324 pushed a commit that referenced this pull request Jan 5, 2024
@github-actions
chore(main): release 0.7.10 (#107)
a268e81 
🤖 I have created a release *beep* *boop*
---


##
[0.7.10](v0.7.9...v0.7.10)
(2024-01-05)


### Build System or External Dependencies

* **deps:** Bump github.com/onsi/ginkgo/v2 from 2.13.1 to 2.13.2
([#102](#102))
([91f0e82](91f0e82))


### Bug Fixes

* disable build --ssh test on Windows
([#106](#106))
([e7fe1eb](e7fe1eb))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsiravar vsiravar vsiravar approved these changes

Assignees

@pendo324 pendo324

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pendo324 @vsiravar