Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rudder preference manager refactor #467

Open
wants to merge 6 commits into
base: feature/sdk-2150-refactor-rudderpreferencemanager-class
Choose a base branch
from

Conversation

1abhishekpandey
Copy link
Contributor

Description

Fixed the following issues:

  • UserId was being sent as an empty field. Now, it will not be sent if it is empty.
  • Fixed lifecycle logic.
  • Modified getInt in Shared Preferences to return -1 when the value is not found.
  • Implemented custom getters for all fields in Storage to ensure the latest values are fetched.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Version upgraded (project, README, gradle, podspec etc)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests for the code
  • I have made corresponding changes to the documentation

@1abhishekpandey 1abhishekpandey self-assigned this Jul 19, 2024
@1abhishekpandey 1abhishekpandey requested a review from a team as a code owner July 19, 2024 17:47
Copy link

sonarcloud bot commented Jul 19, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant