-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to mount directly into shadowRoot #18
Comments
@rstacruz thoughts? |
it would really help to pass an extra property to the react root component, which is a reference to the object returned by PS. Also, I don't quite understand why one needs to create an extra |
@rstacruz could you pls review this path I've created to allow use shadowRoot |
Instead of creating a
span
and mounting the React component in there, we could also just mount directly into theshadowRoot
. According to this comment the event system of the latest version of React supportsshadowRoot
now, no retargeting needed. Retargeting is only required when mounting in a child ofshadowRoot
, so why not avoid the problem altogether by not using a child at all?The text was updated successfully, but these errors were encountered: