Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can I synchronize my changes to the main branch? #25

Open
shuxinqin opened this issue Mar 15, 2021 · 2 comments
Open

Can I synchronize my changes to the main branch? #25

shuxinqin opened this issue Mar 15, 2021 · 2 comments

Comments

@shuxinqin
Copy link

Hi, I made some changes to rsocket.net, it supports back pressure and cancel operations now. I'll continue to develop other features next. Can I synchronize my changes to the main branch?
My fork: https://github.com/shuxinqin/rsocket-net
@OlegDokuka
Copy link
Member

Hi @shuxinqin!
That awesome to see some external effort!

Can you please create a PR explaining what is changed?

@shuxinqin
Copy link
Author

I have submitted a PR and look forward to your suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OlegDokuka @shuxinqin