You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While not necessarily a problem, the current lack of namespacing in Ruby does not seem too great to me.
For example Common module is a global constant upon requiring libdnf5/common. I think having a prefix so that it becomes for example LibDNF5::Common (or Libdnf5::Common, or other variations of capitalization) would be better.
I'd apply this to all modules present, but names such as Logger, Common, or Base are IMO more probably to have a clash in other projects than for example Rpm.
There could be a small problem with compatibility, but if LibDNF5 is a module only used for namespacing (with no additional/new methods on it), then it can be included in the global namespace guilt-free:
While not necessarily a problem, the current lack of namespacing in Ruby does not seem too great to me.
For example
Common
module is a global constant upon requiringlibdnf5/common
. I think having a prefix so that it becomes for exampleLibDNF5::Common
(orLibdnf5::Common
, or other variations of capitalization) would be better.I'd apply this to all modules present, but names such as
Logger
,Common
, orBase
are IMO more probably to have a clash in other projects than for example Rpm.There could be a small problem with compatibility, but if
LibDNF5
is a module only used for namespacing (with no additional/new methods on it), then it can be included in the global namespace guilt-free:The text was updated successfully, but these errors were encountered: