Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to implement complex, realtime updated filters as intermediary information streams between sensors and controllers #1796

Open
lcbw opened this issue Oct 15, 2024 · 3 comments

Comments

@lcbw
Copy link

lcbw commented Oct 15, 2024

Is your feature request related to a problem? Please describe.
In ROS1, when my team needed to use a noisy sensor like the default UR e-series FT sensor, we'd filter the sensor data through a simple node that published to some topic '/filtered_wrench' which we could use for our force-based-controller inputs.
Force-based controllers were initialized with some '/force_sensor_wrench' topic to then listen to, which we could remap to our '/filtered_wrench'.

This topic-based approach also enabled us to impose offsets on sensor data. We are looking to impose an offset on FT sensor data used for admittance control in ROS2, in the new native ROS2 control structure.

Describe the solution you'd like
We believe this should be possible currently through the capability to expose and share hardware and state interfaces between broadcasters and controllers inheriting from the chained controllers class. If a simpler solution is available, all the better.

Describe alternatives you've considered
We've tried utilizing the exponential filter present in the ros2_controllers admittance controller to process the FT noise but this does not meet our need to be able to impose an offset on the force torque data.

Additional context
This request is based in work on the following platforms and software versions:

ROS2 | Humble | Ubuntu 22.04 | UR10e | Polyscope 5.11

@bmagyar
Copy link
Member

bmagyar commented Oct 17, 2024

On first read it sounds like you are looking for ros-controls/ros2_controllers#1215

@lcbw
Copy link
Author

lcbw commented Oct 17, 2024

On first read it sounds like you are looking for ros-controls/ros2_controllers#1215
Thank you.

Does the review team intend on merging this PR? If so, is there a timeline on the review, fixes, and merge?

This PR is close to what I'm looking for, and will do the trick for now once I get it building in humble, which it currently is not. An ideal solution would enable me to read both offset and non-offset sensor data in separate streams.

@saikishor
Copy link
Member

@lcbw with that you can start one broadcast let with offsets and another one without any offsets, so you have two data streams as you wanted ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants