Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default color: PolygonZoneAnnotator, drawing functions #1587

Closed
LinasKo opened this issue Oct 10, 2024 · 8 comments · Fixed by #1591
Closed

Add default color: PolygonZoneAnnotator, drawing functions #1587

LinasKo opened this issue Oct 10, 2024 · 8 comments · Fixed by #1591
Assignees
Labels
hacktoberfest Open for contributions during the annual Hacktoberfest event, aimed at encouraging open-source parti

Comments

@LinasKo
Copy link
Collaborator

LinasKo commented Oct 10, 2024

Add default color: PolygonZoneAnnotator, drawing functions

Tip

Hacktoberfest is calling! Whether it's your first PR or your 50th, you’re helping shape the future of open source. Help us build the most reliable and user-friendly computer vision library out there! 🌱

In a recent stream, we noticed that some drawing functions and annotators require you to specify a color. Please give these a default color!

Of course, we wish to have sv.Color.ROBOFLOW.

Check polygon annotator and draw functions!


Helpful links:

@LinasKo LinasKo added the hacktoberfest Open for contributions during the annual Hacktoberfest event, aimed at encouraging open-source parti label Oct 10, 2024
@souhhmm
Copy link

souhhmm commented Oct 10, 2024

Hey, I am already working on the issue #1585, would it be possible to assign this one to me as well?

@DivyaVijay1234
Copy link
Contributor

Hello, I would like to work on this issue. Please assign it to me.

@LinasKo
Copy link
Collaborator Author

LinasKo commented Oct 10, 2024

@souhhmm, let's see how yours goes first, before taking another 😉

Assigning it to you, @DivyaVijay1234!

@LinasKo
Copy link
Collaborator Author

LinasKo commented Oct 10, 2024

The draw functions I foresee needing this are:

  • draw_line
  • draw_rectangle
  • draw_filled_rectangle
  • draw_polygon
  • draw_filled_polygon

@onuralpszr
Copy link
Collaborator

onuralpszr commented Oct 10, 2024

Hey, I am already working on the issue #1585, would it be possible to assign this one to me as well?

I just wanted to say that Let's give chance to others complete issues and welcome new contributors. Thank you for your understanding :)

@DivyaVijay1234
Copy link
Contributor

Thank you for assigning it to me. I will work on this issue.

@mostafahanafi
Copy link

My fault @LinasKo I didn't see that someone else was already assigned, I just saw an issue with no PR so got to work immediately

@LinasKo
Copy link
Collaborator Author

LinasKo commented Oct 12, 2024

It happens sometimes, @mostafahanafi , don't worry about it.

However, we consider, review and iterate on the solution by the assigned contributor first. Only if that fails would we consider other ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Open for contributions during the annual Hacktoberfest event, aimed at encouraging open-source parti
Projects
None yet
5 participants