Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect Oriented Bounding Box to Metrics #1562

Open
LinasKo opened this issue Oct 3, 2024 · 17 comments
Open

Connect Oriented Bounding Box to Metrics #1562

LinasKo opened this issue Oct 3, 2024 · 17 comments
Assignees
Labels
good first issue Good for newcomers hacktoberfest Open for contributions during the annual Hacktoberfest event, aimed at encouraging open-source parti

Comments

@LinasKo
Copy link
Collaborator

LinasKo commented Oct 3, 2024

Connect Oriented Bounding Box to Metrics

Tip

Hacktoberfest is calling! Whether it's your first PR or your 50th, you’re helping shape the future of open source. Help us build the most reliable and user-friendly computer vision library out there! 🌱


Several new features were recently added to supervision:

  • Mean Average Precision (mAP)
  • F1 Score
  • IoU calculation for Oriented Bounding Boxes

Intersection Over Union (IoU) is the starting point when computing these metrics. It determines which detections are considered true positives. However, take a look! The Oriented Box IoU is not supported yet! Help us add support by using oriented_box_iou_batch.

Helpful links:

@LinasKo LinasKo added good first issue Good for newcomers hacktoberfest Open for contributions during the annual Hacktoberfest event, aimed at encouraging open-source parti labels Oct 3, 2024
@LinasKo
Copy link
Collaborator Author

LinasKo commented Oct 3, 2024

Hi @patel-zeel 👋

I'm moving the IoU integration into metrics here. I believe we spoke about it briefly. Have you done substantial work on it already? If not, I will open it to the community.

@LinasKo
Copy link
Collaborator Author

LinasKo commented Oct 3, 2024

Contribution guidelines

If you would like to make a contribution, please check that no one else is assigned already. Then leave a comment such as "Hi, I would like to work on this issue". We're happy to answer any questions about the task even if you choose not to contribute.

Please share a Google Colab with minimal code to test the new feature. We know it's additional work, but it will speed up the review process. You may use the Starter Template. The reviewer must test each change. Setting up a local environment to do this is time-consuming. Please ensure that Google Colab can be accessed without any issues (make it public). Thank you! 🙏

@Prasadayus
Copy link

Hi ,I would like to work on this issue. Please @LinasKo assign me this issue

@patel-zeel
Copy link
Contributor

Hi @LinasKo, feel free to open it for the community. I'd be happy to help other contributors if they face any issues while implementing :)

@onuralpszr onuralpszr assigned patel-zeel and unassigned patel-zeel Oct 3, 2024
@onuralpszr
Copy link
Collaborator

Hi ,I would like to work on this issue. Please @LinasKo assign me this issue

@Prasadayus hello task is yours, good luck have fun :)

@abhinav7289A
Copy link

Hi @LinasKo I am new to open source contribution. Please assign me this issue as I want to excel in this field

@LinasKo
Copy link
Collaborator Author

LinasKo commented Oct 3, 2024

Hi @abhinav7289A,

This issue is already taken. I'll add many new ones next week - keep an eye on our issue board! 😉

@PrakharJain1509
Copy link

If an issue is already taken and I propose a better solution, then will you consider it or not? @LinasKo

@LinasKo
Copy link
Collaborator Author

LinasKo commented Oct 3, 2024

Hi @PrakharJain1509 👋
No. However, after the initial solution is refined and merged, I'm happy to review PRs that meaningfully improve upon it, even if the issue is closed. This would be eligible for Hacktoberfest as well.

@LinasKo
Copy link
Collaborator Author

LinasKo commented Oct 9, 2024

Hi @Prasadayus 👋

How's it going? Did you find any time to look at oriented boxes and metrics? 😉

@Prasadayus
Copy link

@LinasKo Sorry for the late reply, I was very busy this week. I cloned the project, reviewed the oriented box and will make the changes by the end of this week

@LinasKo
Copy link
Collaborator Author

LinasKo commented Oct 10, 2024

Thank you very much!

@PrakharJain1509
Copy link

@LinasKo I have opened a PR for this issue. Please review it and let me know if any changes are required.

@LinasKo
Copy link
Collaborator Author

LinasKo commented Oct 13, 2024

Thank you very much @PrakharJain1509 ! I'll have a look and review it tomorrow

@LinasKo LinasKo added open-to-multiple-contributors Multiple contributors can work on this issue, but typically, only one submission will be accepted. and removed open-to-multiple-contributors Multiple contributors can work on this issue, but typically, only one submission will be accepted. labels Oct 15, 2024
@LinasKo
Copy link
Collaborator Author

LinasKo commented Oct 15, 2024

I've just realized that @Prasadayus is the original assigned contributor. Your PR will have priority over that of @PrakharJain1509.

@Prasadayus, how goes it? Do you think you'll have time to complete this PR? 😉

@LinasKo
Copy link
Collaborator Author

LinasKo commented Oct 17, 2024

Adding @PrakharJain1509 as an assignee.
Of the two, the first successfully merged contribution will be chosen.

@LinasKo
Copy link
Collaborator Author

LinasKo commented Oct 17, 2024

Accepting #1593 as the solution for adding OBB support for the mAP metric. It needs a lot of cleaning-up, but I like the effort put in.

This ticket also involves the F1 metric. @Prasadayus, will you have the time to look into it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Open for contributions during the annual Hacktoberfest event, aimed at encouraging open-source parti
Projects
None yet
Development

No branches or pull requests

6 participants