Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Expose "FirebaseVisionBarcode" instead of "String" via qrCodeCallback #123

Open
subinsv opened this issue Apr 12, 2020 · 3 comments

Comments

@subinsv
Copy link

subinsv commented Apr 12, 2020

Currently the library only exposes the rawValue of FirebaseVisionBarcode.

Can you expose whole FirebaseVisionBarcode properties via qrCodeCallback. This will allow us to utillize the full potential of Firebase Vision.

FirebaseVisionBarcode Docs

@subinsv subinsv changed the title Expose "FirebaseVisionBarcode" instead of "String" via qrCodeCallback [Feature Request] Expose "FirebaseVisionBarcode" instead of "String" via qrCodeCallback Apr 12, 2020
@rmtmckenzie
Copy link
Owner

Good idea, I'll try to do this in a future update.

@LaxmikanthMadhyastha
Copy link

Hi, this is a very good feature.
Any timeline planned on this?
Thank you.

@LaxmikanthMadhyastha
Copy link

LaxmikanthMadhyastha commented Dec 26, 2020

Hey, @subinsv @rmtmckenzie I have made the changes to expose the Barcode model from firebase instead of just the string.
If that is fine I can create a pull request to merge the same.
You can this in my forked repo here

I have taken this as a reference

Do check it out and let me know if any changes are required :)
I can change the readme as well if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants