Skip to content
This repository has been archived by the owner on Jun 12, 2020. It is now read-only.

Add configurable time-outs for template, proxy and include routes #8

Closed
AndreasKl opened this issue Feb 28, 2018 · 4 comments
Closed
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@AndreasKl
Copy link
Contributor

Currently there is no facility to define a time-out for proxy and base-template routes, this could be added as part of our routing configuration. The more challenging part is to define time-outs for include routes on a per include base.

Notes:

  • Could be implemented as an attribute of the include tag.
@AndreasKl AndreasKl added enhancement New feature or request question Further information is requested labels Feb 28, 2018
@AndreasKl AndreasKl changed the title Add configurable time-outs for template routes and include routes Add configurable time-outs for template, proxy and include routes Feb 28, 2018
@thovid
Copy link
Member

thovid commented Mar 2, 2018

I'd suggest that we have a default timeout for base templates and a separate timeout for content fragments that can be configured via configuration as well as the option to overwrite these default values via an attribute on the include tag.

@AndreasKl
Copy link
Contributor Author

Agree, as long as the request stack allows a "per request" based timeout; otherwise I would just go with the a configurable overall timeout.

@thovid
Copy link
Member

thovid commented Mar 4, 2018

Should be possible to configure a timeout per request: apolloRequest.ttl()

@AndreasKl AndreasKl self-assigned this Mar 10, 2018
@thovid
Copy link
Member

thovid commented Mar 13, 2018

Resolved via #28

@thovid thovid closed this as completed Mar 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants