Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for Revery.UI #810

Open
wezm opened this issue Apr 7, 2020 · 4 comments
Open

Documentation for Revery.UI #810

wezm opened this issue Apr 7, 2020 · 4 comments
Labels
A-docs Area: Documentation bug Something isn't working

Comments

@wezm
Copy link

wezm commented Apr 7, 2020

I cloned and built revery-quick-start and started looking through App.re to see how it all works. I noticed it opens Revery.UI but there didn't seem to be any documentation for things like Opacity and View on https://www.outrunlabs.com/revery/api/revery/. Poking around I managed to guess the URL and found them at https://www.outrunlabs.com/revery/api/revery/revery_ui/ and https://www.outrunlabs.com/revery/api/revery/revery_ui_primitives/

Looks like https://github.com/revery-ui/revery/blob/master/src/index.mld needs to be updated. I've got the docs building locally now. I can open a PR with them added if you like.

@Et7f3
Copy link
Member

Et7f3 commented Apr 7, 2020

Thanks for reporting :) We use odoc to generate documentation. Their is some work to allow to generate programmatically the .mld (and the whole website) so our docs pages will stay up to date. I don't know the state/branch where we can see the progress done.

We can add it manually for now. Do you want I do ?

In case we have forgotten some other modules you can just have the list of argument by peeking inside the source. We respect the rule: "One component per file" so the Opacity component is defined here https://github.com/revery-ui/revery/blob/master/src/UI_Primitives/Opacity.re#L4 You can use the "find file" feature of GitHub to help you :)

@wezm
Copy link
Author

wezm commented Apr 7, 2020

We can add it manually for now. Do you want I do ?

I'm happy to do it if that's what you mean. I worked out how to build the docs already.

@Et7f3
Copy link
Member

Et7f3 commented Apr 7, 2020

Ok open a PR then :) I will review and merge if it is ok :)

@glennsl glennsl added A-docs Area: Documentation bug Something isn't working labels Apr 12, 2020
@chinwobble
Copy link
Contributor

all the links to hooks are also broken in the table of contents.
https://www.outrunlabs.com/revery/api/revery/
If you click on animation, reducer, etc they are broken.

#811 has some code to fix this but the PR was closed :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants