Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: client constructor hostname and port #725

Closed
ejsuncy opened this issue Aug 4, 2016 · 1 comment
Closed

Documentation: client constructor hostname and port #725

ejsuncy opened this issue Aug 4, 2016 · 1 comment

Comments

@ejsuncy
Copy link

ejsuncy commented Aug 4, 2016

The client Horizon model has a constructor that takes an object of option keys and values, one of which is host. It is not apparent from the docs here that the host option is a string that includes the port number if applicable. Perhaps providing an example or two there such as 'host':'localhost:8181' would be more helpful, as I had to dig in to the source to find the constructor of the Horizon object.

I bring this up because I'm developing my web app and using BrowserSync, which serves the static files on port 5555, for example. I'm also using horizon on 8181, and I need to override the default port that Horizon client tries to connect to (in this case, the default was port 5555).

Thanks!

@danielmewes
Copy link
Member

Thanks for the feedback @ejsuncy . I moved your suggestion to the special documentation issue tracker: rethinkdb/horizon-docs#107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants