Rust: more impl<AsComponents> helpers
#8401
Merged
+116
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
commented
Dec 10, 2024
Comment on lines
+26
to
+32
| rec.log_static( | ||
| "images", | ||
| &[ | ||
| &format as &dyn rerun::ComponentBatch, | ||
| &rerun::Image::indicator(), | ||
| ], | ||
| )?; |
There was a problem hiding this comment.
Inference only breaks due to the explicit indicator shenanigans here, which I think is fine since they're going away.
Without the indicator, this would now come down to this:
rec.log_static("images", &format)?;which is pretty neat.
teh-cmc
commented
Dec 10, 2024
| @@ -26,7 +26,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> { | |||
| (glam::Vec3::from(vertex_positions[1]) * factor).into(), | |||
| (glam::Vec3::from(vertex_positions[2]) * factor).into(), | |||
| ]; | |||
| rec.log("triangle", &[&vertex_positions as _])?; | |||
| rec.log("triangle", &vertex_positions)?; | |||
There was a problem hiding this comment.
Inference broke because of the unspecified as _. Now we don't need it at all, so that's just better.
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
teh-cmc
added
enhancement
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12262036501 |
teh-cmc
changed the title
Into<AsComponents> helpersimpl<AsComponents> helpers
Wumpf
approved these changes
Dec 10, 2024
|
Alright, let's see how this goes 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New release, new helpers, as is now customary.
These only introduced two breaking changes in all of our examples and snippets, and they look pretty innocuous.
Opinions?
AsComponentsfor collections ofAsComponents#8398