Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PerStoreStoreSubscriber wrapper to remove store tracking boilerplate #8400

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Dec 10, 2024

Most store subscribers don't need a view over all stores. This removes this indirection from a whole bunch of store subscriber implementors and moves it into a utility.

@Wumpf Wumpf added 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Dec 10, 2024
Copy link

github-actions bot commented Dec 10, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
24b9cb0 https://rerun.io/viewer/pr/8400 +nightly +main

Note: This comment is updated whenever you push a commit.

@teh-cmc teh-cmc self-requested a review December 11, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants