Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify zoom-and-pan area #8390

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Simplify zoom-and-pan area #8390

wants to merge 3 commits into from
+42 −38

Conversation

emilk
Copy link
Member

@emilk emilk commented Dec 10, 2024

  • Simplify the zoom-pan-view
  • Fix the zoom-pan-view eating the viewport highlight rectangle

@emilk emilk added 🪳 bug Something isn't working ui concerns graphical user interface exclude from changelog PRs with this won't show up in CHANGELOG.md egui Requires egui/eframe work feat-graph-view Everything related to the graph view labels Dec 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 10, 2024 •
edited
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link
✅ 3940554 https://rerun.io/viewer/pr/8390

Note: This comment is updated whenever you push a commit.

grtlr
grtlr approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@grtlr grtlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🤩

crates/store/re_chunk_store/src/writes.rs Show resolved Hide resolved
@grtlr grtlr mentioned this pull request Dec 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grtlr grtlr grtlr approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working egui Requires egui/eframe work exclude from changelog PRs with this won't show up in CHANGELOG.md feat-graph-view Everything related to the graph view ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @grtlr