Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Bezier edge-drawing #8379

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve Bezier edge-drawing #8379

wants to merge 2 commits into from

Conversation

grtlr
Copy link
Contributor

@grtlr grtlr commented Dec 10, 2024

What

This fixes a bug where the Bezier-edges would flip and start to intersect instead of fanning out properly. It also removes the hardcoded fan_amount and makes it dependent on the distance of the nodes.

@grtlr grtlr added the exclude from changelog PRs with this won't show up in CHANGELOG.md label Dec 10, 2024
Copy link

github-actions bot commented Dec 10, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link
3b3726c https://rerun.io/viewer/pr/8379

Note: This comment is updated whenever you push a commit.

Base automatically changed from grtlr/force-blueprints to main December 10, 2024 11:36
@grtlr grtlr force-pushed the grtlr/fix-graph-bezier branch from dcc2608 to 9176700 Compare December 10, 2024 11:37
@grtlr grtlr requested a review from abey79 December 10, 2024 11:37
@grtlr grtlr marked this pull request as ready for review December 10, 2024 11:37
@grtlr grtlr force-pushed the grtlr/fix-graph-bezier branch from 9176700 to 3b3726c Compare December 10, 2024 12:15
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

meta note: we generally try to have screenshots in the PR description when it makes sense. Here, a before/after would have been nice ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants