-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding DefaultCamera to Spatial3D view #8211
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,16 @@ | ||||||
namespace rerun.blueprint.archetypes; | ||||||
|
||||||
|
||||||
/// Defines a default camera view. | ||||||
table DefaultCamera ( | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe more like
Suggested change
The problem with
|
||||||
"attr.docs.category": "Spatial 3D", | ||||||
"attr.docs.view_types": "Spatial3DView, Spatial2DView: if logged above active projection", | ||||||
Comment on lines
+6
to
+7
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
We don't use those on property archetypes so far. (also the 2D space view part is obv. wrong) |
||||||
"attr.rust.derive": "Copy, PartialEq", | ||||||
"attr.rerun.scope": "blueprint" | ||||||
) { | ||||||
/// Origin of the camera view. | ||||||
origin: rerun.blueprint.components.CameraOrigin ("attr.rerun.component_optional", nullable, order: 1100); | ||||||
|
||||||
/// Target of the camera view. | ||||||
target: rerun.blueprint.components.CameraTarget ("attr.rerun.component_optional", nullable, order: 1200); | ||||||
Comment on lines
+11
to
+15
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should describe what happens if only one of those is set each |
||||||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
namespace rerun.blueprint.components; | ||
|
||
|
||
/// Origin of a camera. | ||
struct CameraOrigin ( | ||
"attr.rust.derive": "PartialEq, Copy", | ||
"attr.rust.repr": "transparent", | ||
"attr.rerun.scope": "blueprint" | ||
) { | ||
/// Position of the camera origin. | ||
pos: rerun.datatypes.Vec3D (order: 100); | ||
} | ||
|
||
|
||
/// Target of a camera. | ||
struct CameraTarget ( | ||
"attr.rust.derive": "PartialEq, Copy", | ||
"attr.rust.repr": "transparent", | ||
"attr.rerun.scope": "blueprint" | ||
) { | ||
/// Position of the camera target. | ||
pos: rerun.datatypes.Vec3D (order: 100); | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,4 +14,7 @@ table Spatial3DView ( | |
/// If not specified, the default is to show the latest state of each component. | ||
/// If a timeline is specified more than once, the first entry will be used. | ||
time_ranges: rerun.blueprint.archetypes.VisibleTimeRanges (order: 10000); | ||
|
||
/// Configures the default camera position of the 3D view. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. similar as above, should clarify a little bit more what that means |
||
default_camera: rerun.blueprint.archetypes.DefaultCamera (order: 20000); | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should explain more what this is: When is the default camera set, what happens when there is none.