Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split TensorDimension into shape and names #6830

Open
emilk opened this issue Jul 9, 2024 · 0 comments · May be fixed by #8376
Open

Split TensorDimension into shape and names #6830

emilk opened this issue Jul 9, 2024 · 0 comments · May be fixed by #8376
Assignees
@emilk
Labels
🏹 arrow concerning arrow 🪵 Log & send APIs Affects the user-facing API for all languages 🚜 refactor Change the code, not the functionality

Comments

@emilk
Copy link
Member

emilk commented Jul 9, 2024

Replace TensorDimension with two components

  • one for shape (u64)
  • one for dimension names (strings)

Part of simplifying our Arrow schemas and codegen
@emilk emilk added 🏹 arrow concerning arrow 🚜 refactor Change the code, not the functionality 🪵 Log & send APIs Affects the user-facing API for all languages labels Jul 9, 2024
@emilk emilk mentioned this issue Jul 9, 2024
Open
@emilk emilk self-assigned this Jul 9, 2024
This was referenced Jul 10, 2024
Open
Closed
@emilk emilk removed their assignment Aug 5, 2024
@emilk emilk self-assigned this Dec 9, 2024
This was referenced Dec 9, 2024
Draft
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
🏹 arrow concerning arrow 🪵 Log & send APIs Affects the user-facing API for all languages 🚜 refactor Change the code, not the functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tensor shape and dimension names as separate arrow fields rerun-io/rerun
1 participant
@emilk