Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to enhance search bar output #1736

Open
vishal-rajpoot opened this issue Oct 20, 2023 · 4 comments
Open

need to enhance search bar output #1736

vishal-rajpoot opened this issue Oct 20, 2023 · 4 comments
Labels

Comments

@vishal-rajpoot
Copy link

vishal-rajpoot commented Oct 20, 2023

Describe the bug

  • i cloned this repo but not able to run the project. as in package.json we need to add node before bin/serve-site.js in start script.
  • Another thing i noticed is if i click on search bar without typing anything. It will automatically fetch all records i.e 769 and shows empty search. In my point of view this is not a good output after search bar. it should not be visible as empty search.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'package.json'
  2. Click on 'start script'

Expected behavior
In my point of view this is not a good output after search bar. it should not be visible as empty search. Also if i type 2 words .Let's take an example, i'm searching for Amazon so if i type am then it is not showing amazon. i need to write full word amazon then will get results

Screenshots
image
image

Desktop (please complete the following information):

  • OS: [windows 10]
  • Browser [chrome]
  • Version [Version 118.0.5993.88]
@vishal-rajpoot vishal-rajpoot changed the title [Bug] need to enhance search bar output Oct 20, 2023
@dougaitken
Copy link
Member

Valid, thanks for reporting @vishal-rajpoot I'm working on moving the site to another build system and search will hopefully be extremely improved.

@virendrawadher
Copy link

Can someone help me to know why we do replace a-z0-9_ to empty string

@Piyush3199
Copy link
Contributor

Hi @dougaitken ,

I’m interested in contributing to your project and would like to work on issue #1736.
Could you please assign it to me under Hacktober fest 2024 ?

@Cassienicolelair703
Copy link

Cassienicolelair703 commented Oct 4, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants