Normalize double slashes in incoming locations #11924
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1b4bdf8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
commented
Aug 22, 2024
Comment on lines
+543
to
+553
| let toLocation = typeof to === "string" ? parsePath(to) : to; | ||
| if (toLocation.pathname) { | ||
| toLocation.pathname = normalizeMultipleSlashes(toLocation.pathname); | ||
| } | ||
| let location: Readonly<Location> = { | ||
| pathname: typeof current === "string" ? current : current.pathname, | ||
| pathname: normalizeMultipleSlashes( | ||
| typeof current === "string" ? current : current.pathname | ||
| ), | ||
| search: "", | ||
| hash: "", | ||
| ...(typeof to === "string" ? parsePath(to) : to), | ||
| ...toLocation, |
There was a problem hiding this comment.
I'm curious if we think this is too widespread. There is a very targeted fix we could put in createURL that just fixes scenarios we expect would throw. By doing it here are a bit more robust and effectively sanitize when we create Location's for the router. We do then expose Location's back out to the user so it might be a concern of that feeling "breaking" to mess with incoming paths in a different manner...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11911