-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpc: bazelize rpc_gen_cycling_test #24400
base: dev
Are you sure you want to change the base?
Conversation
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/59130#0193894b-3fad-453d-8464-4814f5197a37 |
i thought cpu!=1 might have been to blame, but that looks ok. maybe it needs
|
It does need to be marked exclusive, but I wouldn't expect a segfault from that... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks marvelous - just a few things. The cert gen macros are chefs kiss so well done
private_key = certificate + ".key" | ||
|
||
pr_key_gen = name + "_key_gen" | ||
native.genrule( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These macros are awesome - thank you for adding them. No need to change anything but generally it's recommended to use run_binary over genrule because run_binary is much more strict about inputs and thus can be cached better.
https://github.com/bazelbuild/bazel-skylib/blob/main/docs/run_binary_doc.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to know! i'll try to replace them 👍
74f7f87
to
afd764d
Compare
|
turns out the segmentation is not related to |
Implements:
CORE-7594 :
rpc_gen_cycling_test.cc
Backports Required
Release Notes